Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async and receiver transmitter #19

Merged
merged 29 commits into from
Jan 19, 2024
Merged

Async and receiver transmitter #19

merged 29 commits into from
Jan 19, 2024

Conversation

Angeleon
Copy link
Contributor

No description provided.

Robert108 and others added 17 commits November 16, 2023 14:29
@Robert108
Switch tcp acceptor to async
1963de8 
The old accept method made the tcp thread blocking until a connection was made.
This was not cleanly cancelable from out side the thread.
This commit adds the acceptor.cancel() method stop all pending accepts,
freeing the thread
@Robert108
Spin udp threads on start
15fcb38
@Robert108
Remove some thread prints
b7a12fa
@Robert108
Clean up TestObject destructor
06b4f7f
@Robert108
Fix busy wait in udp threads
e92b40a
@Robert108
FIx traj size
1559746
@Robert108
Update HEAD timeout print
cab6672
@Robert108
Add shutdown function
87b2f62
@Robert108
Only send MONR when a HEAB has been received (ie the endpoint is reso…
dee1ddc 
…lved)
@Robert108
Change sigslot submodule to use https
d46b07c
@Robert108
Update iso22133 submodule ref
bfbc41c
@Robert108
Fix faulty url
11d67db
@Robert108
Call shutdown in destructor
a66833e
@Robert108
Reset context on disconnect
a9f0017
@victorjarlow
fix, removed unused header
2842fbb
rebase and fix merge between two prs
7227dcd
Rebased and fixed tests
82e5a89
@Robert108
Copy link
Contributor

This branch has been tested and validated with these changes running in the FTCApp and Carla simulation application context.

@Robert108 Robert108 self-requested a review January 12, 2024 07:20
Robert108
Robert108 requested changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@Robert108 Robert108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I left some suggestions to make the code a bit more readable and follow iso22133 terminology closer

inc/tcpServer.hpp Show resolved Hide resolved
src/iso22133object.cpp Outdated Show resolved Hide resolved
src/iso22133object.cpp Outdated Show resolved Hide resolved
src/iso22133state.cpp Outdated Show resolved Hide resolved
tests/isoObject.cpp Outdated Show resolved Hide resolved
tests/isoObject.cpp Outdated Show resolved Hide resolved
tests/isoObject.cpp Outdated Show resolved Hide resolved
tests/isoObject.cpp Show resolved Hide resolved
tests/isoObject.cpp Outdated Show resolved Hide resolved
tests/isoObject.cpp Show resolved Hide resolved
oscjoha
oscjoha requested changes Jan 12, 2024
View reviewed changes
.vscode/settings.json Outdated Show resolved Hide resolved
inc/iso22133object.hpp Outdated Show resolved Hide resolved
src/iso22133object.cpp Outdated Show resolved Hide resolved
inc/iso22133object.hpp Outdated Show resolved Hide resolved
inc/iso22133object.hpp Outdated Show resolved Hide resolved
inc/iso22133object.hpp Outdated Show resolved Hide resolved
Patrik Lönnberg and others added 7 commits January 15, 2024 13:36
@Robert108
Update src/iso22133object.cpp
2368b21 
Co-authored-by: Robert Brenick <[email protected]>
@Robert108
Update src/iso22133object.cpp
d02ffea 
Co-authored-by: Robert Brenick <[email protected]>
@Robert108
Update src/iso22133state.cpp
9b69bee 
Co-authored-by: Robert Brenick <[email protected]>
@Robert108
Update tests/isoObject.cpp
d27392a 
Co-authored-by: Robert Brenick <[email protected]>
@Robert108
Update tests/isoObject.cpp
9014a6b 
Co-authored-by: Robert Brenick <[email protected]>
@Robert108
Update tests/isoObject.cpp
1fe62c2 
Co-authored-by: Robert Brenick <[email protected]>
@oscjoha
Update src/iso22133object.cpp
b0eb86a 
Co-authored-by: Oscar Johansson <[email protected]>
Patrik Lönnberg and others added 2 commits January 15, 2024 13:37
@Robert108 Robert108 self-requested a review January 16, 2024 14:35
@oscjoha
Copy link
Member

oscjoha commented Jan 19, 2024

Looks good, can we close #1 now?

@Robert108
Copy link
Contributor

@oscjoha yes

@oscjoha oscjoha mentioned this pull request Jan 19, 2024
Closed
@Angeleon Angeleon merged commit 3ce6d06 into master Jan 19, 2024
1 check passed
@Angeleon Angeleon deleted the Async_and_receiver_transmitter_id branch January 19, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscjoha oscjoha oscjoha approved these changes

@Robert108 Robert108 Robert108 approved these changes

@victorjarlow victorjarlow Awaiting requested review from victorjarlow

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Angeleon @Robert108 @oscjoha @victorjarlow