Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command should be called by clients and executed on server #1233

Closed
stilnat opened this issue Aug 4, 2023 · 2 comments · Fixed by #1234
Closed

Command should be called by clients and executed on server #1233

stilnat opened this issue Aug 4, 2023 · 2 comments · Fixed by #1234
Labels
Feature A new system or other feature.

Comments

@stilnat
Copy link
Contributor

stilnat commented Aug 4, 2023

Summary

Currently, some commands (the console command popping when pressing F12) have to be launch from host (since it's also server), and it doesn't allow a client admin to execute commands such as spawning items server wise.
Find a way to allow authorized clients to execute commands server side.

Possible solutions

Alain's suggestion :

you could mark a command as "run on server"
if the command parser on the client gets a command with that info, it sends the whole command string to the server
the server uses the same parser and actually executes the command

IamTeapot suggested to use a decorator (need more info)

@stilnat stilnat added the Feature A new system or other feature. label Aug 4, 2023
@xk0fe
Copy link
Contributor

xk0fe commented Aug 6, 2023

Why not send command request to the server, server verifies admin rights of a sender and then executes the command?

@stilnat
Copy link
Contributor Author

stilnat commented Aug 6, 2023

that's the idea, the only thing I'dd add is the possibility to execute command on clients in some cases, PR #1234 should solve this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature A new system or other feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants