Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Modernizing the exercises page #388

Merged
merged 2 commits into from
Apr 5, 2024
Merged

Conversation

yammesicka
Copy link
Member

No description provided.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @yammesicka - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Docstrings: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

Comment on lines +96 to +99
#exercises-page-container {
display: flex;
justify-content: center;
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (code_refinement): Consider using responsive units for width in #exercises-page.

Using a fixed width (720px) may not be responsive across all devices. Consider using percentages or viewport width (vw) for better responsiveness.

Suggested change
#exercises-page-container {
display: flex;
justify-content: center;
}
#exercises-page-container {
display: flex;
justify-content: center;
width: 80vw; /* Adjust the width to use viewport width for better responsiveness */
}

@yammesicka yammesicka merged commit e775a2b into master Apr 5, 2024
2 of 3 checks passed
@yammesicka yammesicka deleted the exercises-are-now-buttons branch April 5, 2024 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant