Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: refactor log storage #11

Open
bpbradley opened this issue Nov 9, 2021 · 0 comments
Open

storage: refactor log storage #11

bpbradley opened this issue Nov 9, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@bpbradley
Copy link
Collaborator

Currently (as of #8) new data (when notification to a client fails) is appended to a flash circular buffer, and then when the client becomes available it is pulled out from the front in a FIFO format and sent to the client. #8 details a number of issues with this implementation, but it is the best way to meet the current requirements (i.e. all the data is sent through a notification the same way that new samples are).

I propose a different system where data is simply appended to a file on a littlefs mount, and the client will download it when needed, possibly leveraging mcumgr to handle this. This comes with some additional corner cases, but it will be a much more scalable solution.

New data can still be sent through the notification when the client is available.

@bpbradley bpbradley added the enhancement New feature or request label Nov 9, 2021
@bpbradley bpbradley self-assigned this Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant