Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't use position but positions in get_player_by_position #342

Merged
merged 2 commits into from
Oct 22, 2024
Merged

don't use position but positions in get_player_by_position #342

merged 2 commits into from
Oct 22, 2024

Conversation

DriesDeprest
Copy link
Contributor

No description provided.

JanVanHaaren
JanVanHaaren reviewed Aug 18, 2024
View reviewed changes
Copy link
Collaborator

@JanVanHaaren JanVanHaaren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution.

Could you please add tests for this change?

@DriesDeprest
Copy link
Contributor Author

@JanVanHaaren done

JanVanHaaren
JanVanHaaren approved these changes Aug 19, 2024
View reviewed changes
Copy link
Collaborator

@JanVanHaaren JanVanHaaren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request looks good to me. Thank you!

@koenvo koenvo added this to the 3.16.0 milestone Oct 22, 2024
@koenvo koenvo merged commit b6d2452 into PySport:master Oct 22, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanVanHaaren JanVanHaaren JanVanHaaren approved these changes

Assignees

@koenvo koenvo

Labels
None yet
Projects
None yet
Milestone
3.16.0
Development

Successfully merging this pull request may close these issues.
3 participants
@DriesDeprest @JanVanHaaren @koenvo