Time-based positions + MinutedPlayed Aggregator #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge must be merged
koenvo
changed the title
There was a problem hiding this comment.
Nice contribution @koenvo! I only have a few minor suggestions.
JanVanHaaren
requested review from
JanVanHaaren
and removed request for
probberechts
JanVanHaaren
approved these changes
Jun 20, 2024
probberechts
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
TimeContainerto handle properties that change during a match, like Player Position, or Team Formationinitial_positionas the Position of a player from the metadata. ThePlayer.positionis pointing to the newTimeContainer.lastvalueEventDatasetAggregatorandMinutesPlayedAggregator. This returns the minutes played for a player, possible with position.