From f703fab6d8b4c6df1898090a8abf9c9e839bc528 Mon Sep 17 00:00:00 2001 From: PunishedPineapple <50609717+PunishedPineapple@users.noreply.github.com> Date: Wed, 24 Aug 2022 20:06:57 -0500 Subject: [PATCH] Disabling nameplate functionality since it appears to be partially broken in ClientStructs for 6.2 --- Distance/Plugin.cs | 2 +- Distance/PluginUI.cs | 7 +++++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/Distance/Plugin.cs b/Distance/Plugin.cs index e2d53d8..85514d3 100644 --- a/Distance/Plugin.cs +++ b/Distance/Plugin.cs @@ -92,7 +92,7 @@ public Plugin( mPluginInterface.UiBuilder.Draw += DrawUI; mPluginInterface.UiBuilder.OpenConfigUi += DrawConfigUI; mUI.Initialize(); - NameplateHandler.Init( sigScanner, clientState, partyList, condition, gameGui, mConfiguration ); + //NameplateHandler.Init( sigScanner, clientState, partyList, condition, gameGui, mConfiguration ); //***** TODO: Disabled because nameplates appear to be broken in ClientStructs for 6.2. // We need to disable automatic hiding, because we actually turn off our game UI nodes in the draw functions as-appropriate, so we can't skip the draw functions. mPluginInterface.UiBuilder.DisableAutomaticUiHide = true; diff --git a/Distance/PluginUI.cs b/Distance/PluginUI.cs index 193ef81..af4e5a1 100644 --- a/Distance/PluginUI.cs +++ b/Distance/PluginUI.cs @@ -95,7 +95,8 @@ protected void DrawSettingsWindow() { ImGui.Checkbox( Loc.Localize( "Config Option: Show Aggro Distance", "Show the remaining distance from the enemy before they will detect you." ) + "###Show aggro distance.", ref mConfiguration.mShowAggroDistance ); ImGuiUtils.HelpMarker( Loc.Localize( "Help: Show Aggro Distance", "This distance will only be shown when it is known, and only on major bosses. Additionally, it will only be shown until you enter combat." ) ); - ImGui.Checkbox( Loc.Localize( "Config Option: Show Nameplate Distances", "Show distances on nameplates." ) + "###Show nameplate distances.", ref mConfiguration.NameplateDistancesConfig.mShowNameplateDistances ); + //***** TODO: Nameplates are broken in 6.2; commenting out settings until fixed. + //ImGui.Checkbox( Loc.Localize( "Config Option: Show Nameplate Distances", "Show distances on nameplates." ) + "###Show nameplate distances.", ref mConfiguration.NameplateDistancesConfig.mShowNameplateDistances ); if( mConfiguration.ShowAggroDistance ) { @@ -187,6 +188,8 @@ protected void DrawSettingsWindow() } } + //***** TODO: Nameplates are broken in 6.2; commenting out settings until fixed. + /* if( mConfiguration.NameplateDistancesConfig.ShowNameplateDistances ) { if( ImGui.CollapsingHeader( Loc.Localize( "Config Section Header: Nameplate Settings", "Nameplate Settings" ) + "###Nameplate Settings Header." ) ) @@ -252,7 +255,7 @@ protected void DrawSettingsWindow() ImGui.TreePop(); } } - } + }*/ if( ImGui.CollapsingHeader( Loc.Localize( "Config Section Header: Miscellaneous", "Miscellaneous Options" ) + "###Misc. Options Header." ) ) {