Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

randomShuffle is not working correctly #167

Open
bargalya opened this issue May 17, 2022 · 4 comments
Open

randomShuffle is not working correctly #167

bargalya opened this issue May 17, 2022 · 4 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@bargalya
Copy link
Contributor

Scenario:

  1. enter the home page
  2. refresh the page and look at the cards order

ER: the order of the cards should change randomly on each refresh
CR: the cards order remains the same on each refresh
@jordy-m
Copy link
Contributor

jordy-m commented May 17, 2022

I'd like to take this issue :)

@MichalPorag MichalPorag added good first issue Good for newcomers bug Something isn't working labels May 17, 2022
@InbarDanieli
Copy link
Contributor

I'd like to take the issue

@Yedidyar
Copy link
Contributor

Yedidyar commented Jun 28, 2022 •
edited
Loading

I tried to investigate the root of this bug.

I narrowed it down to a bug in the build process because it works in the development environment.

My guess is that the page is build once on new build(SSG) and does not revalidate the shuffled people and clear the cached static page on refresh.

Yedidyar added a commit to Yedidyar/pull-request-community-website that referenced this issue Jun 29, 2022
@Yedidyar
fix: randomShuffle isn't working correctly (Pull-Request-Community#167)
837c834
MichalPorag pushed a commit that referenced this issue Jul 2, 2022
@Yedidyar
Yedidyar/issue167 (#240)
b452576 
* feat: add Yedidya Rashi profile (#220)

* fix: randomShuffle isn't working correctly  (#167)
@Yedidyar
Copy link
Contributor

Yedidyar commented Jul 4, 2022 •
edited
Loading

Resolved at #240

please close the issue

MichalPorag pushed a commit that referenced this issue Jul 8, 2022
@Noamili @Yedidyar
@OmriBarZik @shir22 @lirantal @InbarDanieli @noamilsh
Staging (#254)
84d56ac 
* feat: add Yedidya Rashi profile (#220)

* chore: remove idea folder (#236)

* updating readme: custom image (#239)

* test: add e2e infra with playwright and a sample test (#235)

* test: add e2e infra with playwright and a sample test

* test: add github action for e2e test

* test: add config for framework spin-up

* Yedidyar/issue167 (#240)

* feat: add Yedidya Rashi profile (#220)

* fix: randomShuffle isn't working correctly  (#167)

* fix(Description): wrap descriptionHeight with useEffect (#243)

see more about the issue:
https://stackoverflow.com/questions/62336340/cannot-update-a-component-while-rendering-a-different-component-warning

* There is no background for the role of Former admin label
Fixes #241

* Test (#238)

* inital commit

* revert change

Co-authored-by: noa <[email protected]>

Co-authored-by: yedidya rashi <[email protected]>
Co-authored-by: Omri Bar-Zik <[email protected]>
Co-authored-by: shir22 <[email protected]>
Co-authored-by: Liran Tal <[email protected]>
Co-authored-by: Inbar Danieli <[email protected]>
Co-authored-by: noa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@bargalya @jordy-m @Yedidyar @MichalPorag @InbarDanieli