Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

47 update devcontainer to include developer dependencies #80

Merged
merged 7 commits into from
Jul 29, 2024

Conversation

joshes
Copy link
Contributor

@joshes joshes commented Jul 5, 2024

Description

Fixes #47

Aligns the development container with the documentation with regards to tools and dependencies.

  • Uses non-root user
  • Uses poetry
  • Uses all extra developer dependencies

Works as expected in my tests, both on local VSCode and Codespaces environments.

@joshes joshes linked an issue Jul 5, 2024 that may be closed by this pull request
@cla-bot cla-bot bot added the cla-signed label Jul 5, 2024
Copy link
Contributor

@sammorley-short sammorley-short left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Josh. LGTM;MWR 🚀

@joshes joshes force-pushed the 47-update-devcontainer-to-include-developer-dependencies branch from b6b3527 to 3a5d1c2 Compare July 29, 2024 22:56
@joshes joshes merged commit 95cee63 into main Jul 29, 2024
8 checks passed
@joshes joshes deleted the 47-update-devcontainer-to-include-developer-dependencies branch July 29, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Update devcontainer to include developer dependencies
3 participants