Update limitations.md #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sammorley-short
requested changes
May 2, 2024
| ## Repeated subroutines | ||
|
|
||
| Currently bartiq does not support a case where a particular subroutine is repeated multiple times, which is a common case in many algorithms, such as trotterization. It is definitely an important feature which will be added in future releases. |
There was a problem hiding this comment.
This isn't strictly true. In the case where the routine acts on the same registers, you can definitely reproduce this effect by having a "repeat" routine that wraps the iterated routine. The real trouble however occurs with things like recursive definitions, like QFT, or for iterations which target different rails, such as in QPE's CU's (where you have to effectively control on the whole phase register).
So I'd suggest updating this to clarify this subtlety.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.