Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing Rollup warnings #937

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Fixing Rollup warnings #937

merged 1 commit into from
Oct 1, 2024

Conversation

Pauan
Copy link
Collaborator

@Pauan Pauan commented Oct 1, 2024

This fixes some Rollup warnings:

  • Circular dependencies have been fixed by shuffling some things into other files.
  • Test warnings have been fixed.

This does not change the behavior at all, it is purely internal refactoring.

jaketarnow
jaketarnow approved these changes Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@jaketarnow jaketarnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaketarnow jaketarnow merged commit 8f729e1 into ProvableHQ:testnet3 Oct 1, 2024
11 of 12 checks passed
@Pauan Pauan deleted the fix/circular-dependencies branch October 1, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaketarnow jaketarnow jaketarnow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pauan @jaketarnow