This repository has been archived by the owner on Aug 12, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 52
Spelling #1
Open
jsoref
wants to merge
24
commits into
ProtonVPN:master
Choose a base branch
from
jsoref:spelling
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Spelling #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoref
commented
Jan 30, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I try to exclude third party components (if I missed some, please let me know, and if you can identify their upstream, I can eventually try to send similar fixes to them).
I generally try to flag API changes. I'm happy to split them out/drop them as requested.
@@ -10,7 +10,7 @@ | |||
<objects> | |||
<customObject id="-2" userLabel="File's Owner" customClass="ServerInfoViewController" customModule="ProtonVPN" customModuleProvider="target"> | |||
<connections> | |||
<outlet property="bottonConstraint" destination="Yya-Tn-hs2" id="lJK-PE-4gu"/> | |||
<outlet property="buttonConstraint" destination="Yya-Tn-hs2" id="lJK-PE-4gu"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's always hard to figure out if people want button
or bottom
when they write botton
. I've made a guess, but I have zero confidence in my guess.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated by https://github.com/jsoref/spelling
f
; to maintain your repo, please considerfchurn