-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backward compatiblity with older redis versions #133
Backward compatiblity with older redis versions #133
Conversation
36b2655
to
9407858
Compare
…with redis version < 5 Signed-off-by: Immanuel Klinkenberg <[email protected]>
Signed-off-by: Immanuel Klinkenberg <[email protected]>
9407858
to
ab3ba7a
Compare
Signed-off-by: Immanuel Klinkenberg <[email protected]>
31eb85e
to
7350e5f
Compare
Will it work when another redis version to the |
@LKaemmerling Do you miss something here? Would be great if we can have an open conversation about this MR. Would love to see it merged soon. Our metrics are growing and it is actually not possible to reset the counters on application level for us. |
Sorry for the late reply, i'm actually quite busy and the only one who tries to look over this.
@drieschel yes this should work. You can try it. |
Thank you! |
Thanks to you @LKaemmerling. |
Hi there!
This PR adds backward compatiblity with redis versions lower 5. Wiping the redis storage did not work without the added command
redis.replicate_commands()
.According to the redis documentation this command is deprecated in redis 7 but it still exists for backward compatiblity with older redis versions (see here).
We are using a redis 4 cluster and cannot upgrade it easily. So this MR helps us to get this component running without changing it externally.
Also others seem to have the same problem, ie #130 .