Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installation instructions to use miniforge/mamba #491

Merged
merged 3 commits into from
Sep 30, 2024

Conversation

ktyle
Copy link
Contributor

@ktyle ktyle commented Sep 30, 2024

Addresses #391

@ktyle ktyle requested a review from a team as a code owner September 30, 2024 15:04
@ktyle ktyle requested review from clyne and brian-rose and removed request for a team September 30, 2024 15:04
Copy link

github-actions bot commented Sep 30, 2024

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: 62e277e
✅ Deployment Preview URL: https://ProjectPythia.github.io/pythia-foundations/_preview/491

@ktyle
Copy link
Contributor Author

ktyle commented Sep 30, 2024

A couple of links to NOAA NCEI are failing. These are due to impacts from Hurricane Helene and should eventually work again.

@dopplershift
Copy link
Contributor

Ignoring the expected link check failures in order to finally get this in.

@dopplershift dopplershift merged commit 173510e into ProjectPythia:main Sep 30, 2024
2 of 3 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 30, 2024
Copy link
Member

@brian-rose brian-rose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @ktyle, just one small recommended addition.


1. It's quicker and takes up less disk space.
2. It encourages you to install only the packages you need in reproducible isolated environments for specific projects. This is generally a more robust way to work with open source tools.
3. It uses `conda-forge` as the default channel for packages.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, but might not mean much to the newbie. Here's my suggested addition:

Suggested change
3. It uses `conda-forge` as the default channel for packages.
3. It uses `conda-forge` as the default channel, which is our recommended way to get up-to-date, interoperable packages.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, looks like I clicked the merge button too quickly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no prob, i'll commit and merge the suggestion by @brian-rose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants