Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in the repo path for the binder #79

Open
brian-rose opened this issue Jun 30, 2023 · 1 comment
Open

Bug in the repo path for the binder #79

brian-rose opened this issue Jun 30, 2023 · 1 comment
Labels
bug Issues that present a reasonable conviction there is a reproducible bug. infrastructure Infrastructure related issue

Comments

@brian-rose
Copy link
Member

brian-rose commented Jun 30, 2023

This line in the build-book.yaml workflow assumes that a PR originates from

--repo ${{ github.actor }}/$CI_REPOSITORY_NAME

and send this as input to binderbot when we need to point to the current PR branch to build a new image on the binder (because of a change in the environment file).

But this logic assumes that the PR branch is always in ${{ github.actor }}'s personal GitHub space. If someone who is a member of the ProjectPythia org opens a PR from a branch owned by the organization, it fails.

The reason it fails is because ${{ github.actor }} points to that person's user name, but the repo name is actually ProjectPythia/$CI_REPOSITORY_NAME.

An example is ProjectPythia/na-cordex-viz-cookbook#7.

Note that when you edit a file directly on GitHub it defaults to creating a new branch within the org, which is what happened in the above example.

@brian-rose brian-rose added the bug Issues that present a reasonable conviction there is a reproducible bug. label Jun 30, 2023
@brian-rose brian-rose added the infrastructure Infrastructure related issue label Oct 2, 2023
@brian-rose
Copy link
Member Author

In ProjectPythia/na-cordex-viz-cookbook#13 we found another version of this same failure. The PR branch is https://github.com/bonnland/na-cordex-viz-cookbook/tree/fix-environment, but when I closed and reopened the PR just to trigger a rebuild, the build failed because the Binder was looking for the code under my user-name:

It shouldn't matter who clicks the "reopen" button! The Binder should always be pointed toward the PR branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues that present a reasonable conviction there is a reproducible bug. infrastructure Infrastructure related issue
Projects
Status: Backlog
Development

No branches or pull requests

1 participant