Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seaport 1.2 #940

Draft
wants to merge 1,604 commits into
base: seaport-1.1
Choose a base branch
from
Draft

Seaport 1.2 #940

wants to merge 1,604 commits into from

Conversation

0age
Copy link
Contributor

@0age 0age commented Jan 28, 2023

This PR highlights changes from Seaport 1.1 to Seaport 1.2 and is meant to facilitate review and discussion of those changes.

djviau and others added 30 commits January 17, 2023 09:03
…-fails-after-counter-increment

add test for failing validation of signed order after counter is incremented
…enforcement-of-conduits

document revert behavior where incorrect conduit key is provided
getMetadata => getSeaportMetadata (with Schema array)
Add HH + forge test for contract orders w native token offers
@github-actions github-actions bot added the Stale label May 9, 2023
@0age 0age added Informational and removed Stale labels May 10, 2023
@ProjectOpenSea ProjectOpenSea deleted a comment from github-actions bot May 23, 2023
@ryanio ryanio marked this pull request as draft April 16, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants