Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: URLs in configs must be strings, not JS URL objects #556

Merged
merged 1 commit into from
Sep 24, 2024
Merged

fix: URLs in configs must be strings, not JS URL objects #556

merged 1 commit into from
Sep 24, 2024

Conversation

JoeCap08055
Copy link
Contributor

Problem

The recent refactor to configs changed the internal representation of URL config values from string -> JS URL object. This caused some problems.

Solution

Revert to string representation of URLs.

mattheworris
mattheworris approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@mattheworris mattheworris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it

@JoeCap08055 JoeCap08055 merged commit 348f57b into main Sep 24, 2024
13 checks passed
@JoeCap08055 JoeCap08055 deleted the fix/config-urls-must-be-strings branch September 24, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattheworris mattheworris mattheworris approved these changes

@aramikm aramikm Awaiting requested review from aramikm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoeCap08055 @mattheworris