Name change: Amplica Labs -> Project Liberty Labs #347
Conversation
wilwade
requested review from
mattheworris,
claireolmstead,
saraswatpuneet and
JoeCap08055
and removed request for
saraswatpuneet
wilwade
force-pushed
the
chore/name-update
branch
from
9084a93
to
eeea8c0
Compare
| @@ -186,7 +186,7 @@ | |||
| same "printed page" as the copyright notice for easier | |||
| identification within third-party archives. | |||
|
|
|||
| Copyright Amplica Labs | |||
| Copyright Project Liberty LLC | |||
There was a problem hiding this comment.
In SAT, you put Copyright 2024 Project Liberty LLC. Do we want to keep it consistent with or without the date?
There was a problem hiding this comment.
The date is optional per copyright patterns. We likely shouldn't have it anywhere, but I was just replacing when going through these.
So this is the "more" correct version, but both are fine.
services/account/LICENSE
Outdated
There was a problem hiding this comment.
why was this deleted?
There was a problem hiding this comment.
I imagine we only need a LICENSE file at the root of the repo
There was a problem hiding this comment.
Yup. Only need the one License file now that it is unified
There was a problem hiding this comment.
Some package locks have only 6 lines changing and some have a ton. Why?
There was a problem hiding this comment.
Good question! I allowed dependency trees to be updated. I removed the lock file and reran npm i to make sure it cleared out any old stuff.
| "devDependencies": { | ||
| "tsx": "^4.15.7" | ||
| } | ||
| "name": "setup", |
There was a problem hiding this comment.
confirming format has been run
There was a problem hiding this comment.
This is actually from npm formatting it I believe. That said, I ran make format and it had formatting changes elsewhere, so I'll push that up as well.
Updating:
No Amplica references should remain.
Closes: #345