Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for task update updating to same status #981

Merged
merged 3 commits into from
May 22, 2024
Merged

Conversation

neildsouth
Copy link
Collaborator

Description

Fixes # .

with a task update message that has the same as the current status, this fix ensures it logs out a lower priority log message and returns true, stopping the message being rejected with all of the retries that causes.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog

@neildsouth neildsouth added the enhancement New feature or request label May 20, 2024
Copy link

sonarcloud bot commented May 20, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 70%)

See analysis details on SonarCloud

@neildsouth neildsouth merged commit ab67db7 into develop May 22, 2024
20 of 21 checks passed
@neildsouth neildsouth deleted the nds-fixstuschange branch May 22, 2024 14:21
@mocsharp mocsharp modified the milestones: 0.1.30, 0.2.0 Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants