Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to override shm-size with docker plug-in #978

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

mocsharp
Copy link
Collaborator

@mocsharp mocsharp commented Apr 4, 2024

Description

Allow the users to override the size of /dev/shm with the Docker plug-in.

Example usage:

"args": {
	"container_image": "ghcr.io/mmelqin/monai_ai_livertumor_seg_app:1.0",
	"server_url": "unix:///var/run/docker.sock",
	"entrypoint": "/bin/bash,-c",
	"command": "python3 -u /opt/monai/app/app.py",
	"task_timeout_minutes": "5",
	"shm_size": "64000000000"
},

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog

@mocsharp mocsharp added enhancement New feature or request plugin labels Apr 4, 2024
@mocsharp mocsharp added this to the 0.2.0 milestone Apr 4, 2024
@mocsharp mocsharp self-assigned this Apr 4, 2024
Copy link

sonarcloud bot commented Apr 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 70%)

See analysis details on SonarCloud

Copy link

sonarcloud bot commented May 23, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 70%)

See analysis details on SonarCloud

Update sonarcloud integration

Signed-off-by: Victor Chang <[email protected]>
@mocsharp mocsharp modified the milestones: 0.2.0, 0.2.1 Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request plugin
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant