Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor fixes #873

Merged
merged 5 commits into from
Sep 8, 2023
Merged

minor fixes #873

merged 5 commits into from
Sep 8, 2023

Conversation

lillie-dae
Copy link
Collaborator

@lillie-dae lillie-dae commented Sep 8, 2023

Description

some minor fixes to variable naming and minor warnings and errors

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog

Signed-off-by: Lillie Dae <[email protected]>
@lillie-dae lillie-dae closed this Sep 8, 2023
Signed-off-by: Lillie Dae <[email protected]>
Signed-off-by: Lillie Dae <[email protected]>
Signed-off-by: Lillie Dae <[email protected]>
@lillie-dae lillie-dae reopened this Sep 8, 2023
Signed-off-by: Lillie Dae <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Sep 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

81.2% 81.2% Coverage
2.0% 2.0% Duplication

warning The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@lillie-dae lillie-dae merged commit bf94fe8 into develop Sep 8, 2023
22 checks passed
@mocsharp mocsharp deleted the MinorFixs branch June 11, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants