Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/0.1.27 #868

Merged
merged 24 commits into from
Aug 24, 2023
Merged

Release/0.1.27 #868

merged 24 commits into from
Aug 24, 2023

Conversation

neildsouth
Copy link
Collaborator

Description
functionality for remote app execution

#859
#858

Status [READY]

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog

neildsouth and others added 24 commits July 24, 2023 11:43
Signed-off-by: Neil South <[email protected]>
Signed-off-by: Neil South <[email protected]>
Signed-off-by: Neil South <[email protected]>
Signed-off-by: Neil South <[email protected]>
Signed-off-by: Neil South <[email protected]>
Signed-off-by: Neil South <[email protected]>
Signed-off-by: Neil South <[email protected]>
Signed-off-by: Neil South <[email protected]>
Signed-off-by: Neil South <[email protected]>
Signed-off-by: Neil South <[email protected]>
Signed-off-by: Neil South <[email protected]>
Signed-off-by: Neil South <[email protected]>
Signed-off-by: Neil South <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Aug 24, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 3 Bugs
Vulnerability E 6 Vulnerabilities
Security Hotspot E 7 Security Hotspots
Code Smell A 352 Code Smells

79.8% 79.8% Coverage
0.2% 0.2% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@@ -28,48 +28,48 @@ public class ClinicalReviewRequestEvent : EventBase
/// </summary>
[JsonProperty(PropertyName = "workflow_instance_id")]
[Required]
public string WorkflowInstanceId { get; set; }
public string WorkflowInstanceId { get; set; } = string.Empty;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to initialise all these if they're required?

@@ -0,0 +1,28 @@
/*
* Copyright 2022 MONAI Consortium
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it need to be 2023?

@neildsouth neildsouth merged commit 8808c16 into main Aug 24, 2023
31 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants