Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring #865

Merged
merged 15 commits into from
Aug 23, 2023
Merged

Refactoring #865

merged 15 commits into from
Aug 23, 2023

Conversation

neildsouth
Copy link
Collaborator

Description

Fixes # .

removed a lot of warnings and also changed some namespaces and even a project name

Status

Read

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog

@neildsouth
adding some tests around new fields
6b7a0e7 
Signed-off-by: Neil South <[email protected]>
@neildsouth
adding validation
821329f 
Signed-off-by: Neil South <[email protected]>
@neildsouth
merge in develop
329ca35 
Signed-off-by: Neil South <[email protected]>
@neildsouth
fixups
6771080 
Signed-off-by: Neil South <[email protected]>
@neildsouth
fix up packages and warnings
2c2f29b 
Signed-off-by: Neil South <[email protected]>
@neildsouth
clean up
df4d04d 
Signed-off-by: Neil South <[email protected]>
@neildsouth
fix up tests
de58640 
Signed-off-by: Neil South <[email protected]>
@neildsouth
fixed up more warnings
dc32471 
Signed-off-by: Neil South <[email protected]>
@neildsouth
refactoring and fixing warnings
06928b2 
Signed-off-by: Neil South <[email protected]>
@neildsouth
more refactoring
5536de3 
Signed-off-by: Neil South <[email protected]>
@neildsouth
total reoranize
f143ecd 
Signed-off-by: Neil South <[email protected]>
@neildsouth
Merge remote-tracking branch 'origin/develop' into refactoring
a3815d0
@neildsouth
fix up merge
1512ab7 
Signed-off-by: Neil South <[email protected]>
@neildsouth neildsouth added the enhancement New feature or request label Aug 22, 2023
mocsharp
mocsharp approved these changes Aug 22, 2023
View reviewed changes
Copy link
Collaborator

@mocsharp mocsharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we retain WorkflowManager in the namespace and the assembly names similar to other projects.

@sonarcloud
Copy link

sonarcloud bot commented Aug 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 10 Code Smells

77.6% 77.6% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@neildsouth neildsouth merged commit 6fd4ef2 into develop Aug 23, 2023
22 checks passed
@neildsouth neildsouth deleted the refactoring branch August 23, 2023 16:16
@mocsharp
Copy link
Collaborator

LGTM! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mocsharp mocsharp mocsharp approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neildsouth @mocsharp