Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

External app #864

Merged
merged 4 commits into from
Aug 22, 2023
Merged

External app #864

merged 4 commits into from
Aug 22, 2023

Conversation

neildsouth
Copy link
Collaborator

Description

adding external app functionality

Status

Work in progress

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog

@neildsouth neildsouth added the enhancement New feature or request label Aug 18, 2023
@neildsouth
external app code
c1c0aa9 
Signed-off-by: Neil South <[email protected]>
@neildsouth
adding more tests
e6d004a 
Signed-off-by: Neil South <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Aug 22, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability E 1 Vulnerability
Security Hotspot A 0 Security Hotspots
Code Smell A 51 Code Smells

73.4% 73.4% Coverage
0.6% 0.6% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@neildsouth neildsouth merged commit 99bcbeb into develop Aug 22, 2023
21 of 22 checks passed
@neildsouth neildsouth deleted the externalApp branch August 22, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielNuttall-AD DanielNuttall-AD DanielNuttall-AD approved these changes

@mehranrashid mehranrashid mehranrashid approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neildsouth @DanielNuttall-AD @mehranrashid