Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Auto generated Argo code #492

Open
neildsouth opened this issue Oct 7, 2022 · 2 comments
Open

Remove Auto generated Argo code #492

neildsouth opened this issue Oct 7, 2022 · 2 comments
Labels
enhancement New feature or request Tech debt Technical debt
Milestone

Comments

@neildsouth
Copy link
Collaborator

Code in ArgoGeneratedCocde.cs has been generated from the Argo swagger, but the /log endpoint produces malformed Json, this has lead to the file being changed manually, not an ideal situation.

The code need implementing from scratch to include only the endpoints used and so then be customized to get around any issues

@neildsouth neildsouth added enhancement New feature or request Tech debt Technical debt labels Oct 7, 2022
@neildsouth neildsouth added this to the 0.2 milestone Oct 7, 2022
@mocsharp
Copy link
Collaborator

The generated code is being used by the Argo plugin for simple API calls; it does not support streaming APIs such as streaming logs. For complex data structures, it is recommended to use HttpClient directly.

@neildsouth neildsouth modified the milestones: 0.2.0, 0.30 Dec 15, 2022
@neildsouth
Copy link
Collaborator Author

moved to the 0.3 milestone, as its not on the work schedule ATM

@woodheadio woodheadio changed the title Remove Auto generated Agro code Remove Auto generated Argo code Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Tech debt Technical debt
Projects
Status: No status
Development

No branches or pull requests

2 participants