You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This would lead to a slight miscalculation in when it is necessary to renew leases (early on one side of UTC and tardy on the other).
VoucherStore was recently changed to use UTC-aware datetimes but the lease maintenance code still uses datetime.utcfromtimestamp with reactor.seconds() and the stored lease expiration time as arguments. It's not immediately obvious to me whether these are correct or not.
The text was updated successfully, but these errors were encountered:
reactor.seconds() is from the system time? And at least on Linux that is UTC. No idea what windows will do.
(Do we have to use reactor.seconds() there, or can we just use aware_now() as well so we don't have to think about this again?)
This would lead to a slight miscalculation in when it is necessary to renew leases (early on one side of UTC and tardy on the other).
VoucherStore
was recently changed to use UTC-aware datetimes but the lease maintenance code still usesdatetime.utcfromtimestamp
withreactor.seconds()
and the stored lease expiration time as arguments. It's not immediately obvious to me whether these are correct or not.The text was updated successfully, but these errors were encountered: