Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pc1.20.5 protocol #898

Merged
merged 19 commits into from
Oct 12, 2024
Merged

Pc1.20.5 protocol #898

merged 19 commits into from
Oct 12, 2024

Conversation

extremeheat
Copy link
Member

No description provided.

@extremeheat
Copy link
Member Author

Extractor is not working correctly per PrismarineJS/minecraft-data-generator#23

but i've fixed the issues here manually for now

@extremeheat
Copy link
Member Author

There are significant changes to the item encoding which involves removing NBT in favor of custom binary encoded "component" data for items. There is still alot of work to do there and it will require some custom types: for example, in block set (https://wiki.vg/Slot_Data#Block_Set) the length of an array is the value of a field - 1.

Some work was started in this commit to implement the changes 05a854f

Everything needs to be implemented, as we cannot decode an array of slots without being 100% correct in encode/decode as it will break parsing of all following entries in an array.

This was referenced Jul 26, 2024
@N4M3L355
Copy link

ping

@BlockyBlockling
Copy link

ping

I think @extremeheat is working on this PrismarineJS/minecraft-data-generator#25 to then get the Recipe error fixed for all the newer Versions. If you're trying to find out why this has halted.

@N4M3L355
Copy link

N4M3L355 commented Sep 15, 2024

oh hello i didn't know somebody will actually respond, thank you for this info and thank everybody for working on this.

@BlockyBlockling
Copy link

Yeah I'm trying to get to help with this since one month but @extremeheat does not seem to have the time to show the Problems or fix it for now.

@QvixoteRoux
Copy link

I wanna stay updated for 1.21.x

thanks

@MightyPiggie
Copy link

I wanna stay updated for 1.21.x

thanks

No need to reply. You can just stay updated by clicking the subscribe button.

@rom1504
Copy link
Member

rom1504 commented Oct 4, 2024

1 failing

  1. audit recipes pc 1.20.5
    crafting benches has multiple recipes:

    AssertionError [ERR_ASSERTION]: 1 != 1

@rom1504
Copy link
Member

rom1504 commented Oct 12, 2024

recipe for crafting table are indeed wrong; missing all the variant wood recipes

still let's not block; will edit the test

@rom1504
Copy link
Member

rom1504 commented Oct 12, 2024

#917 for tracking

@rom1504 rom1504 merged commit a240b84 into PrismarineJS:master Oct 12, 2024
4 checks passed
@rom1504
Copy link
Member

rom1504 commented Oct 12, 2024

merging to simplify updates

further fixes can be done in another PR

@rom1504
Copy link
Member

rom1504 commented Oct 12, 2024

/makerelease

@rom1504bot rom1504bot mentioned this pull request Oct 12, 2024
@rom1504
Copy link
Member

rom1504 commented Oct 12, 2024

/makerelease

@rom1504bot rom1504bot mentioned this pull request Oct 12, 2024
@rom1504
Copy link
Member

rom1504 commented Oct 12, 2024

/makerelease

@rom1504bot rom1504bot mentioned this pull request Oct 12, 2024
@rom1504
Copy link
Member

rom1504 commented Oct 12, 2024

/makerelease

@rom1504bot rom1504bot mentioned this pull request Oct 12, 2024
@rom1504
Copy link
Member

rom1504 commented Oct 12, 2024

/makerelease

@rom1504bot rom1504bot mentioned this pull request Oct 12, 2024
@rom1504
Copy link
Member

rom1504 commented Oct 12, 2024

/makerelease

@rom1504bot rom1504bot mentioned this pull request Oct 12, 2024
@rom1504
Copy link
Member

rom1504 commented Oct 13, 2024

/makerelease

@rom1504bot rom1504bot mentioned this pull request Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

6 participants