Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to effects data, add data for Bedrock #695

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

extremeheat
Copy link
Member

@extremeheat extremeheat commented Mar 4, 2023

  • Add protocolName (name in registry), modifiers and color to effects data
  • modifiers list what attribute the effect modifies, the amount and the operation done (add/multiply)
  • add neutral as a category for effects, fix some neutral effects being assigned bad type
  • pc: Remove effects files where there was no change from previous version, also fixes issue with duplicate effect IDs in 1.14
  • Add effects data for bedrock

Manually updated with script from mc source

@extremeheat extremeheat requested a review from u9g March 4, 2023 08:49
@rom1504
Copy link
Member

rom1504 commented Mar 4, 2023

Manually updated with script from mc source

can you add a pointer to this in the new version guide ?

@rom1504
Copy link
Member

rom1504 commented Mar 4, 2023

I see you deleted a bunch of effect file, can you

  • explain why
  • if there's a good reason, adapt data load file

@extremeheat
Copy link
Member Author

For the deleted files, I removed the files where there was no change from the previous version and just pointed the dataPath to the version that it was last changed

@rom1504
Copy link
Member

rom1504 commented May 20, 2023

I'm not sure convinced about deleting most version files

usually we kept files for each versions

but anyway can you at least resolve the conflict?

@rom1504
Copy link
Member

rom1504 commented Jun 3, 2023

@extremeheat should we merge this?

@extremeheat
Copy link
Member Author

I'm not sure convinced about deleting most version files

I re added some of the unchanged JSONs

@extremeheat should we merge this?

Yeah, I fixed the conflict, should be possible to merge now.

@rom1504
Copy link
Member

rom1504 commented Jul 24, 2023

Sorry conflict again. can you resolve it ?

@rom1504
Copy link
Member

rom1504 commented Aug 5, 2023

conflict + CI failing

@rom1504
Copy link
Member

rom1504 commented Dec 29, 2023

more conflict, @extremeheat let's try to finish this one

@extremeheat
Copy link
Member Author

Will check this out sometime this week, will need to also update the extractor for 1.20

@extremeheat
Copy link
Member Author

Did some work on this, but still need to continue working on script to handle all the versions correctly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Needs triage
Development

Successfully merging this pull request may close these issues.

2 participants