MNK Single Target Combo

[Evolutious]

Hi @PrincessRTFM - I spent some time learning a bit of this C# and was able to make a full Single Target combo for MNK. I am providing it here in the event you have any desire to use it, either in part or in full. This is fairly customized to fit into my fork of your code, so some stuff might not align exactly, but I am certain you can get a sense of what all I did. I have been playing with this for a week or so and have not found any further refinements needed.

This will let you literally play MNK single target with a single button and be within 90% of optimal (depending on positioning in fights for uptime and group buffs aligning).

If you find methods to further enhance (which I am certain you will!), feel to adopt and let me know! I am just starting out in this stuff and learning all I can; mainly from you :)

	internal class MonkSTCombo: CustomCombo {
		public override CustomComboPreset Preset { get; } = CustomComboPreset.MonkSTCombo;
		public override uint[] ActionIDs => new[] { MNK.Bootshine };
		protected override uint Invoke(uint actionID, uint lastComboMove, float comboTime, byte level) {
			MNKGauge gauge = GetJobGauge<MNKGauge>();

			// *** oGCD Rotation ***
			if (CanWeave(MNK.Bootshine)) {
				// Bloodbath
				if (level >= MNK.Levels.Bloodbath && IsOffCooldown(MNK.Bloodbath) && PlayerHealthPercentage < 75) { return MNK.Bloodbath; }
				// Riddle of Earth
				if (level >= MNK.Levels.RiddleofEarth && IsOffCooldown(MNK.RiddleofEarth) && PlayerHealthPercentage < 50) { return MNK.RiddleofEarth; }
				// Steel Peak/The Forbidden Chakra
				if (level >= MNK.Levels.Meditation && gauge.Chakra == 5 && InCombat) { return OriginalHook(MNK.Meditation); }
				// Perfect Balance
				if (level >= MNK.Levels.PerfectBalance && !SelfHasEffect(MNK.Buffs.PerfectBalance)) {
					if (level >= MNK.Levels.Brotherhood && SelfHasEffect(MNK.Buffs.RiddleOfFire) && SelfEffectDuration(MNK.Buffs.RiddleOfFire) < 10.0 && !SelfHasEffect(MNK.Buffs.FormlessFist) && SelfHasEffect(MNK.Buffs.DisciplinedFist) && SelfHasEffect(MNK.Buffs.Brotherhood)) { return MNK.PerfectBalance; }
					else if (level >= MNK.Levels.RiddleOfFire && SelfHasEffect(MNK.Buffs.RiddleOfFire) && SelfEffectDuration(MNK.Buffs.RiddleOfFire) >= 10.0 && !SelfHasEffect(MNK.Buffs.FormlessFist) && SelfHasEffect(MNK.Buffs.DisciplinedFist)) { return MNK.PerfectBalance; }
					else if (level >= MNK.Levels.FormShift && level < MNK.Levels.RiddleOfFire && !SelfHasEffect(MNK.Buffs.FormlessFist) && SelfHasEffect(MNK.Buffs.DisciplinedFist)) { return MNK.PerfectBalance; }
					else if (level < MNK.Levels.FormShift && SelfHasEffect(MNK.Buffs.DisciplinedFist)) { return MNK.PerfectBalance; }
				}
				// Riddle of Fire
				if (level >= MNK.Levels.RiddleOfFire && !IsOnCooldown(MNK.RiddleOfFire) && SelfHasEffect(MNK.Buffs.DisciplinedFist)) { return MNK.RiddleOfFire; }
				// Brotherhood
				if (level >= MNK.Levels.Brotherhood && SelfHasEffect(MNK.Buffs.PerfectBalance) && !IsOnCooldown(MNK.Brotherhood) && (gauge.BeastChakra.Contains(BeastChakra.RAPTOR) || gauge.BeastChakra.Contains(BeastChakra.COEURL) || gauge.BeastChakra.Contains(BeastChakra.OPOOPO))) { return MNK.Brotherhood; }
				// Riddle of Wind
				if (level >= MNK.Levels.RiddleOfWind && !IsOnCooldown(MNK.RiddleOfWind) && IsOnCooldown(MNK.RiddleOfFire)) { return MNK.RiddleOfWind; }
			}
			// Masterful Blitz
			if (level >= MNK.Levels.MasterfulBlitz && !gauge.BeastChakra.Contains(BeastChakra.NONE)) { return OriginalHook(MNK.MasterfulBlitz); }
			// Master's Gauge
			if (level >= MNK.Levels.PerfectBalance && SelfHasEffect(MNK.Buffs.PerfectBalance)) {
				// Solar
				if (level >= MNK.Levels.EnhancedPerfectBalance && !gauge.Nadi.HasFlag(Nadi.SOLAR)) {
					if (!gauge.BeastChakra.Contains(BeastChakra.RAPTOR)) {
						return MNK.TwinSnakes;
					}
					if (!gauge.BeastChakra.Contains(BeastChakra.COEURL)) {
						return (level < MNK.Levels.Demolish || TargetFindOwnEffect(MNK.Debuffs.Demolish)?.RemainingTime > 6.0)
							? MNK.SnapPunch
							: MNK.Demolish;
					}
					if (!gauge.BeastChakra.Contains(BeastChakra.OPOOPO)) {
						return (level < MNK.Levels.DragonKick || SelfHasEffect(MNK.Buffs.LeadenFist))
							? MNK.Bootshine
							: MNK.DragonKick;
					}
					return (level >= MNK.Levels.DragonKick)
						? MNK.DragonKick
						: MNK.Bootshine;
				}
				// Lunar.  Also used if we have both Nadi as Tornado Kick/Phantom Rush isn't picky, or under 60.
				return (level < MNK.Levels.DragonKick || SelfHasEffect(MNK.Buffs.LeadenFist))
					? MNK.Bootshine
					: MNK.DragonKick;
			}
			// 1-2-3 combo
			if (level >= MNK.Levels.TrueStrike && (SelfHasEffect(MNK.Buffs.RaptorForm) || SelfHasEffect(MNK.Buffs.FormlessFist))) {
				return (level < MNK.Levels.TwinSnakes)
					? MNK.TrueStrike
					: MNK.TwinSnakes;
			}
			if (level >= MNK.Levels.SnapPunch && SelfHasEffect(MNK.Buffs.CoerlForm)) {
				return (level < MNK.Levels.Demolish || TargetFindOwnEffect(MNK.Debuffs.Demolish)?.RemainingTime > 6.0)
					? MNK.SnapPunch
					: MNK.Demolish;
			}
			if (SelfHasEffect(MNK.Buffs.OpoOpoForm)) {
				return (level < MNK.Levels.DragonKick || SelfHasEffect(MNK.Buffs.LeadenFist))
					? MNK.Bootshine
					: MNK.DragonKick;
			}
			// Dragon Kick
			return (level < MNK.Levels.DragonKick || SelfHasEffect(MNK.Buffs.LeadenFist))
				? MNK.Bootshine
				: MNK.DragonKick;
		}
	}

[PrincessRTFM]

I'll definitely grab this and take a closer look!

[PrincessRTFM]

Actually, the same issue happens with Brotherhood.

[Evolutious]

I just check FFLogs to find the buff ID that is being applied. Here is the full list of the buffs i use.

		public static class Buffs {
			public const ushort
				OpoOpoForm = 107,
				RaptorForm = 108,
				CoerlForm = 109,
				PerfectBalance = 110,
				LeadenFist = 1861,
				Brotherhood = 1185,
				RiddleOfFire = 1181,
				FormlessFist = 2513,
				DisciplinedFist = 3001;
		}

[PrincessRTFM]

Perfect. I've made a couple of tweaks, mostly to style/readability but also making a few threshold values adjustable, and I've credited you in the source. I'll be pushing this live shortly, although for now it's tagged as experimental purely because I can't test it myself and I don't know how it'll interact with any other combos active; once I know that, I can assign any conflict tags it needs and remove the experimental flag.

[Evolutious]

Fantastic! Thanks :D

As for what could conflict; likely anything that changes any of the imbedded actions in a manner outside of the variables that I am using could cause a conflict, but most will likely be unnoticeable. on my fork, I literally tore down all MNK features and only have this ST and your AoE (adopting a few routines I built in my ST). Might be a good idea to just mark the other options as conflicting in your options panel so if they select one, it unselects the ST combo.

[PrincessRTFM]

I'll probably do that, yeah. Also, if you want to contribute more, feel free to open pull requests! Just try to conform to the project's .editorconfig settings, and I'm working on some general internal cleanup for conditionals to make it easier to read/maintain the code.