Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limitation: structure made to only build 1 theme #6

Open
bm-services opened this issue Jun 13, 2017 · 2 comments
Open

Limitation: structure made to only build 1 theme #6

bm-services opened this issue Jun 13, 2017 · 2 comments

Comments

@bm-services
Copy link

We made a modification to build the theme you want (set a variable in gulpfile.js), if you are intereted in, take a look to this fork : https://github.com/BMServices/email-templates-sdk

We commented the CSS injection for now

@Scritik
Copy link
Contributor

Scritik commented Jun 19, 2017

Hi @bm-services,

Thank you for you contribution. This is an interesting feature.
I think that you shouldn't force the THEME variable. Try to set it as param so we can run multiple Gulp at the same time to work on multiple themes.

Regarding the CSS injection, it was a temporary solution until MJML introduce its own tag: https://mjml.io/documentation/#mjml-style
We will remove it asap.

Do not hesitate to make a PR when all your changes are clean ;)

@bm-services
Copy link
Author

Hi @Scritik,
we finally built the new version with theme name as an argument and improve some parts of the script.

A PR has just been made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants