This repository has been archived by the owner on Feb 3, 2021. It is now read-only.
[*] MO: ganalytics anonymizeIp feature added as selectable option #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @justb81, Because we deal with an improvement of the module, you should set your upgrade file for 2.4.0. Translations are not mandatory, but it is even better if you can add many of them. 😃 Thanks a lot for your contribution. :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the anonymizeIp-Feature for Google Analytics as a selectable setting in the configure-dialog as asked in #84
i didn't added the form-controls to the
form-ps14.tpl, because the userid feature wasn't added there, too. at the moment i did not add translations for the new feature. is this needed for the PR to be accepted?I added a new
Upgrade-2.3.4.phpfile, to set a default value to the config.