Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Worker does not template ECSTask family #289

Closed
EmilRex opened this issue Jun 22, 2023 · 1 comment · Fixed by #398
Closed

Worker does not template ECSTask family #289

EmilRex opened this issue Jun 22, 2023 · 1 comment · Fixed by #398
Assignees

Comments

@EmilRex
Copy link
Contributor

EmilRex commented Jun 22, 2023

PR #152 changed the behavior of the family top-level settings on the ECSTask infrastructure block. Rather than just being set to prefect, it instead templates using the flow and deployment names: prefect__{flow-name}__{deployment-name}. This change does not seem to have made it into the worker. When users have multiple heterogeneous deployments, using a single family (prefect) can lead to excessive task definition revisions and may trigger service rate limits.

@bennnym
Copy link

bennnym commented Jul 21, 2023

any progress on this @EmilRex - feels quite silly having to input a family override for each deployment as a hot fix...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants