-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Minecraft Wiki): add presence #8300
Conversation
How can I test it on my PC? |
Check out the development documentation. Specifically, you'll want to clone my repo/branch, install the dependencies, and run |
This comment was marked as resolved.
This comment was marked as resolved.
Strange. That could be an extension-side issue. |
Now waiting on PreMiD/Localization#7410 |
This comment was marked as resolved.
This comment was marked as resolved.
Oh, okay! Got it!
You're welcome! I'm glad to know I could help somehow. Also, thanks for all the work you did to make this presence, by the way! I appreciate it. |
0af9cac
to
8a0c2e3
Compare
15ad715
to
2655dc1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- When inside a watchlist, I think "Viewing their subscriptions" is more related to a service than actually in the context of the Wiki, y'know? I get it and there's sense in it, but I'd say adding the label "Viewing their watchlist" or something else rather than "subscriptions" to these pages still. It isn't a "subscription" but pages you decide to watch and keep an eye on and get notifications when users change it.
- Creating an account displays "Logging in". It makes sense, so it's okay.
–
After this, if I don't find anything else, I think this presence will be a 100% complete and ready to go once minecraft wiki.*
strings gets approved! Again, huge thanks to you for making this presence and doing all these changes! It's truly amazing the result we managed to achieve.
41961c5
to
cf207f0
Compare
Description
Acknowledgements
yarn format
Screenshots
Proof showing the creation/modification is working as expected