Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Minecraft Wiki): add presence #8300

Merged
merged 25 commits into from
Apr 28, 2024

Conversation

theusaf
Copy link
Member

@theusaf theusaf commented Apr 25, 2024

Description

Acknowledgements

Screenshots

Proof showing the creation/modification is working as expected

image
image
image

kau19an

This comment was marked as resolved.

@theusaf theusaf requested review from Bas950 and kau19an April 25, 2024 19:18
@kau19an
Copy link

kau19an commented Apr 25, 2024

How can I test it on my PC?

@theusaf
Copy link
Member Author

theusaf commented Apr 25, 2024

How can I test it on my PC?

Check out the development documentation. Specifically, you'll want to clone my repo/branch, install the dependencies, and run npx pmd to "modify" the Minecraft Wiki presence. Then, follow the instructions listed in the documentation to load the presence into your extension

kau19an

This comment was marked as resolved.

@theusaf

This comment was marked as resolved.

@kau19an
Copy link

kau19an commented Apr 25, 2024

The labels you see are already translated. You can use the language selector in the Presence's settings to select the language you want.

Well, mine has "Portuguese" selected but still displays English to me in some labels.

image
image

@theusaf
Copy link
Member Author

theusaf commented Apr 25, 2024

Strange. That could be an extension-side issue.

@theusaf
Copy link
Member Author

theusaf commented Apr 25, 2024

Now waiting on PreMiD/Localization#7410

@theusaf
Copy link
Member Author

theusaf commented Apr 25, 2024

New screenshots with changes

2024-04-25 15_42_22
2024-04-25 15_42_40

@theusaf theusaf requested a review from kau19an April 25, 2024 22:47
kau19an

This comment was marked as resolved.

@theusaf

This comment was marked as resolved.

@theusaf theusaf marked this pull request as draft April 26, 2024 02:08
@kau19an
Copy link

kau19an commented Apr 26, 2024

The issue of minecraft wiki.x is not going to be resolved until the localization pr is merged.

Oh, okay! Got it!

Anyways, thanks for doing these tests.

You're welcome! I'm glad to know I could help somehow. Also, thanks for all the work you did to make this presence, by the way! I appreciate it.

@theusaf theusaf force-pushed the minecraft-wiki/feat/2024-04-24 branch from 0af9cac to 8a0c2e3 Compare April 26, 2024 03:16
@theusaf theusaf marked this pull request as ready for review April 26, 2024 03:37
@theusaf theusaf requested a review from kau19an April 26, 2024 03:37
kau19an

This comment was marked as resolved.

Timeraa
Timeraa previously approved these changes Apr 26, 2024
@theusaf theusaf force-pushed the minecraft-wiki/feat/2024-04-24 branch from 15ad715 to 2655dc1 Compare April 26, 2024 18:31
Copy link

@kau19an kau19an left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. When inside a watchlist, I think "Viewing their subscriptions" is more related to a service than actually in the context of the Wiki, y'know? I get it and there's sense in it, but I'd say adding the label "Viewing their watchlist" or something else rather than "subscriptions" to these pages still. It isn't a "subscription" but pages you decide to watch and keep an eye on and get notifications when users change it.
  • Creating an account displays "Logging in". It makes sense, so it's okay.

After this, if I don't find anything else, I think this presence will be a 100% complete and ready to go once minecraft wiki.* strings gets approved! Again, huge thanks to you for making this presence and doing all these changes! It's truly amazing the result we managed to achieve.

@theusaf theusaf force-pushed the minecraft-wiki/feat/2024-04-24 branch from 41961c5 to cf207f0 Compare April 26, 2024 21:10
@Bas950 Bas950 merged commit 6637eab into PreMiD:main Apr 28, 2024
3 checks passed
@theusaf theusaf deleted the minecraft-wiki/feat/2024-04-24 branch April 28, 2024 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Minecraft Wiki | *.minecraft.wiki
4 participants