Skip to content
This repository has been archived by the owner on Jun 14, 2024. It is now read-only.

Group: fix error if Iis apppool is in local group members #170

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

machgo
Copy link

@machgo machgo commented Sep 4, 2019

Pull Request (PR) description

This PR fixes an error, which occures if the local group has a member with the following format "IIS APPPOOL\xxx". The same problem was already fixed for "NT AUTHORITY\xxx" in dsccommunity/xPSDesiredStateConfiguration#314

This Pull Request (PR) fixes the following issues

none

Task list

  • Added an entry under the Unreleased section in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

Copy link

@gaelcolas gaelcolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, as per other comment, it'd be wise to submit that change to xPSDesiredStateConfiguration.

While I check if the fix should be merged in, could you update the tests to go along with your change please?
https://github.com/PowerShell/PSDscResources/blob/dev/Tests/Unit/MSFT_GroupResource.Tests.ps1#L298-L312

Thanks

Reviewable status: 0 of 2 files reviewed, all discussions resolved

@PlagueHO PlagueHO added the on hold The issue or pull request has been put on hold by a maintainer. label Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
on hold The issue or pull request has been put on hold by a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants