chore: android plugin #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daibhin
approved these changes
Sep 18, 2024
Comment on lines
+3
to
+4
| PosthogReactNativeSessionReplay_targetSdkVersion=34 | ||
| PosthogReactNativeSessionReplay_compileSdkVersion=34 |
There was a problem hiding this comment.
I remember messing with sdk versions was always messy given how fragmented Android was as an ecosystem. I assume the target / compile versions are less important than changing something like the minSdkVersion?
There was a problem hiding this comment.
they are equally important, if you dont compile and target the newest versions, your app can't even ben released in the stores.
this is just a fallback though, in case its not provided by the "final app"
Comment on lines
+29
to
+62
| // OptionalReactNativeSessionReplay.isEnabled().then((isEnabled) => { | ||
| // console.warn('PostHog Debug', `isEnabled: ${isEnabled}`); | ||
| // setResult(isEnabled.valueOf().toString()); | ||
| // }); | ||
| // OptionalReactNativeSessionReplay.startSession( | ||
| // 'e58ed763-928c-4155-bee9-fdbaaadc15f3' | ||
| // ) | ||
| // .then(() => { | ||
| // setResult('ok'); | ||
| // }) | ||
| // .catch(() => { | ||
| // setResult('failed'); | ||
| // }); | ||
| // OptionalReactNativeSessionReplay.start( | ||
| // 'e58ed763-928c-4155-bee9-fdbaaadc15f3', | ||
| // { | ||
| // apiKey: 'phc_QFbR1y41s5sxnNTZoyKG2NJo2RlsCIWkUfdpawgb40D', | ||
| // host: 'https://us.i.posthog.com', | ||
| // }, | ||
| // {}, | ||
| // {} | ||
| // ) | ||
| // .then(() => { | ||
| // OptionalReactNativeSessionReplay?.isEnabled().then((isEnabled) => { | ||
| // console.warn('PostHog Debug', `isEnabled: ${isEnabled}`); | ||
| // setResult(`isEnabled: ${isEnabled}`); | ||
| // }); | ||
| // }) | ||
| // .then(() => { | ||
| // setResult('ok'); | ||
| // }) | ||
| // .catch(() => { | ||
| // setResult('failed'); | ||
| // }); |
There was a problem hiding this comment.
Suggested change
| // OptionalReactNativeSessionReplay.isEnabled().then((isEnabled) => { | |
| // console.warn('PostHog Debug', `isEnabled: ${isEnabled}`); | |
| // setResult(isEnabled.valueOf().toString()); | |
| // }); | |
| // OptionalReactNativeSessionReplay.startSession( | |
| // 'e58ed763-928c-4155-bee9-fdbaaadc15f3' | |
| // ) | |
| // .then(() => { | |
| // setResult('ok'); | |
| // }) | |
| // .catch(() => { | |
| // setResult('failed'); | |
| // }); | |
| // OptionalReactNativeSessionReplay.start( | |
| // 'e58ed763-928c-4155-bee9-fdbaaadc15f3', | |
| // { | |
| // apiKey: 'phc_QFbR1y41s5sxnNTZoyKG2NJo2RlsCIWkUfdpawgb40D', | |
| // host: 'https://us.i.posthog.com', | |
| // }, | |
| // {}, | |
| // {} | |
| // ) | |
| // .then(() => { | |
| // OptionalReactNativeSessionReplay?.isEnabled().then((isEnabled) => { | |
| // console.warn('PostHog Debug', `isEnabled: ${isEnabled}`); | |
| // setResult(`isEnabled: ${isEnabled}`); | |
| // }); | |
| // }) | |
| // .then(() => { | |
| // setResult('ok'); | |
| // }) | |
| // .catch(() => { | |
| // setResult('failed'); | |
| // }); |
There was a problem hiding this comment.
I'd rather keep it since it's for testing the native calls (during development - its just a sample), ideally I'd have a button for each of them, will do it in the next PR with iOS if that's ok
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pinned all the versions that make it work with the other plugins https://github.com/PostHog/posthog-js-lite/tree/main/posthog-react-native
ios is next but should be more straight forward