Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: kwargs in extra_body #188

Merged
merged 2 commits into from
Jul 25, 2024
Merged

hotfix: kwargs in extra_body #188

merged 2 commits into from
Jul 25, 2024

Conversation

csgulati09
Copy link
Collaborator

Title: kwargs in extra_body

Description:

  • OpenAI client doesn't accept kwargs
  • Passed kwargs in extra_body

Motivation:
Our SDK was not accepting and passing safety_settings

Related Issues:
Fixes: #187

@csgulati09 csgulati09 self-assigned this Jul 25, 2024
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jul 25, 2024
@csgulati09 csgulati09 requested a review from VisargD July 25, 2024 13:08
@dosubot dosubot bot added the auto:bug label Jul 25, 2024
@VisargD VisargD merged commit d7ef6e6 into main Jul 25, 2024
5 of 6 checks passed
@VisargD VisargD deleted the hotfix/extraBody branch July 25, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:bug size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PythonSDK: Accepting kwargs
2 participants