Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace #10

Open
Daniel15 opened this issue May 25, 2019 · 2 comments
Open

Namespace #10

Daniel15 opened this issue May 25, 2019 · 2 comments

Comments

@Daniel15
Copy link

Why is JsonObject in the System namespace? That's very confusing because it makes it seem like this is part of the .NET framework (rather than a third-party package), and there's also a JsonObject class in the System.Json namespace (https://docs.microsoft.com/en-us/dotnet/api/system.json.jsonobject?view=dotnet-plat-ext-2.1). Could you please consider moving it to a Pomelo.JsonObject namespace?

@lauxjpn
Copy link
Contributor

lauxjpn commented Jan 24, 2020

@caleblloyd Is there any particular reason for putting JsonObject in the System namespace?

@caleblloyd
Copy link
Contributor

Really just legacy reasons. Changing it would be a BC Break

NPGSQL has JSON support now and they use an interesting approach:

https://www.npgsql.org/efcore/mapping/json.html

Amongst other options, they use the .NET Core 3.0 System.Text.Json APIs

https://devblogs.microsoft.com/dotnet/try-the-new-system-text-json-apis/

Aligning seems like a logical course if we were to break BC anyways

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants