cpp/python: flag to force generation of static methods #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce the __isl_ensure_static macro that forces the generators to make the method static if it would otherwise be an instance member function. This macro is primarily intended for static constructors of an object from another object of the same type, which are present in sets and spaces. Marking such methods as constructors would interfere with standard copy construction. Exporting them directly masks the fact of construction and is inconsistent with other static methods serving as named constructors. Consider readbility of isl::set s = isl::set::from_params(another_set); enabled by this macro against isl::set s = another_set.from_params(); Signed-off-by: Oleksandr Zinenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce the __isl_ensure_static macro that forces the generators to make the
method static if it would otherwise be an instance member function.
This macro is primarily intended for static constructors of an object from
another object of the same type, which are present in sets and spaces. Marking
such methods as constructors would interfere with standard copy construction.
Exporting them directly masks the fact of construction and is inconsistent with
other static methods serving as named constructors. Consider readbility of
enabled by this macro against
Closes #22