[PLBCK-140] Fix for closed captions not showing when seeking into the start of the playlist. #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
issue/246-pluto-xbox-captions
…amController's media property.
jau5mann
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Cherry pick the changes that fixes the closed captions not reapearing when seeking vod to the start. Also added code to comply with the new linter rules and the change on one of the properties being nullable.
Original fix on Avia hls.js pull request,
Why is this Pull Request needed?
Are there any points in the code the reviewer needs to double check?
Resolves issues:
https://plutotv.atlassian.net/browse/PLBCK-140
Checklist