Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

composition: Provide more helpful suggestions to resolve missing resource dependencies #239

Open
ethanjli opened this issue Jun 13, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@ethanjli
Copy link
Member

Currently, including a package deployment with a missing resource dependency on a network service (e.g. as in https://github.com/ethanjli/rpi-forklift-demo?tab=readme-ov-file#modify-a-pallet-safely) can cause plt check/plt stage to print a very long and rather unhelpful error report about package deployments providing the most similar resources (essentially all other package deployments with network services get printed out). Here are some ideas for cleaning up this input:

  • Limit the list of candidate resources to ~5 candidates, and sort them by similarity of unmatched criteria (e.g. string similarity)
  • Consider disabled package deployments as candidates for meeting resource requirements, especially if they match (or are very similar) to the unmatched resource criteria
  • Consider disabled feature flags as candidates for meeting resource requirements, especially if they match (or are very similar) to the unmatched resource criteria
  • Consider packages available in required repos as candidates for meeting resource requirements, even if they don't have an enabled/disabled package deployment associated with them
  • Allow packages' resource requirement objects to include a list of suggested packages (and maybe associated feature flags); then that list will be prioritized, and all candidates in that list will be displayed. If a suggested package is provided by an unknown repo (i.e. a repo which is not among the pallet's requirements), we don't need to show any details about it.
@ethanjli ethanjli added the enhancement New feature or request label Jun 13, 2024
@ethanjli ethanjli self-assigned this Jun 14, 2024
@ethanjli ethanjli added this to the Preprint Nice-to-Haves milestone Jun 14, 2024
@ethanjli ethanjli changed the title Provide more helpful suggestions to resolve missing resource dependencies ui: Provide more helpful suggestions to resolve missing resource dependencies Jun 14, 2024
@ethanjli ethanjli changed the title ui: Provide more helpful suggestions to resolve missing resource dependencies constraints: Provide more helpful suggestions to resolve missing resource dependencies Jun 14, 2024
@ethanjli ethanjli changed the title constraints: Provide more helpful suggestions to resolve missing resource dependencies composition: Provide more helpful suggestions to resolve missing resource dependencies Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant