Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

host/docker: Enable restarting of a package deployment's Compose app #234

Open
ethanjli opened this issue Jun 13, 2024 · 0 comments
Open
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@ethanjli
Copy link
Member

ethanjli commented Jun 13, 2024

Currently, the only programmatic way to restart the Docker containers of a Compose app provided by a package deployment is to guess the names of the containers and pass them to the docker restart command, e.g. as in https://github.com/PlanktoScope/PlanktoScope/blob/e3dbfc7ed25da6c0cd5e3159cf6880f3e3abda38/software/node-red-dashboard/flows/adafruithat.json#L7519 . It would be simpler, cleaner, and easier to run a host restart-app or host restart-depl subcommand which automatically does all that work for us, for a given package deployment name.

An alternative approach (inspired by https://docs.podman.io/en/latest/markdown/podman-systemd.unit.5.html) could be to generate a systemd unit for each package deployment with a Compose app, so that we could use systemctl restart with the name of the package deployment (but with slashes converted to underscores). This would be much more complex to implement, but it would enable us to use systemd for ordering and supervising Compose apps. I'm not sure that is a very salient benefit for the PlanktoScope project at the moment, though.

@ethanjli ethanjli added the enhancement New feature or request label Jun 13, 2024
@ethanjli ethanjli self-assigned this Jun 14, 2024
@ethanjli ethanjli changed the title Enable restarting of a package deployment's Compose app host/docker: Enable restarting of a package deployment's Compose app Jun 14, 2024
@ethanjli ethanjli added this to the Backlog milestone Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant