Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring/stepper.py #36

Open
wants to merge 41 commits into
base: main
Choose a base branch
from

Conversation

Oumayma-hy
Copy link
Contributor

@Oumayma-hy Oumayma-hy commented May 16, 2024

The code in this pull request has been tested.
The stepper.py file has been refactored into two separate files: pump.py and focus.py.

@Oumayma-hy
Copy link
Contributor Author

The error " Value of type Optional[Any] is not indexable" has been resolved by adding a comment to ignore type errors on those lines. The errors that remain are linked to missing library stubs or py.typed marker.

@Oumayma-hy
Copy link
Contributor Author

I resolved the linter errors related to comments by adding necessary documentation, but I ignored other linter errors that would make the code difficult to read, such as enforcing Python 3 styles. Additionally, the code has not been tested due to issues with the Planktoscope on site.

@ethanjli ethanjli self-requested a review August 23, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants