Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UsdImagingDataSourceAttributeNew doesn't support color4 #3298

Open
robpieke opened this issue Sep 18, 2024 · 2 comments
Open

UsdImagingDataSourceAttributeNew doesn't support color4 #3298

robpieke opened this issue Sep 18, 2024 · 2 comments

Comments

@robpieke
Copy link
Contributor

robpieke commented Sep 18, 2024

In dataSourceAttribute.cpp the _FactoryMap has entries for Color3f and Color3fArray but not Color4f or Color4fArray. The result of this is that any shading node which has a color4f parameter will not have a value generated.

For example:

        def Shader "mtlxover1"
        {
            uniform token info:id = "ND_over_color4"
            color4f inputs:bg = (0.9, 0.1, 0.6, 1)
            color4f inputs:fg.connect = </materials/collect1/mtlxtiledimage1.outputs:out>
            color3f outputs:out
        }

In this case, the bg parameter ends up generating no value.

@jesschimein
Copy link
Contributor

Filed as internal issue #USD-10149

@robpieke
Copy link
Contributor Author

The _FactoryMap is also missing:

     map[SdfValueTypeNames->Double3] = _FactoryImpl<GfVec3d>;
     map[SdfValueTypeNames->Int64Array] = _FactoryImpl<VtArray<int64_t>>;
     map[SdfValueTypeNames->Int64] = _FactoryImpl<int64_t>;
     map[SdfValueTypeNames->Vector3dArray] = _FactoryImpl<VtArray<GfVec3d>>;
     map[SdfValueTypeNames->Vector3d] = _FactoryImpl<GfVec3d>;

This is not meant to be a comprehensive list ... just the ones we've noticed so far.

robp-sidefx added a commit to sideeffects/USD that referenced this issue Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants