You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Some of the MaterialX shader codegen uses unordered data structures, and this reflects in the output shader. This causes problems for tests which are comparing against a static baseline. For example, testHdStMaterialXShaderGen_UsdPStextured has these lines
This is because the lines are printed in the order of _mxHdTextureMap, which is a MaterialX::StringMap aka std::unordered_map<std::string, std::string> (see pxr/imaging/hdSt/materialXShaderGen.cpp).
Either the testing baseline check needs to be smarter to handle undefined ordering where they can occur, or the codegen needs to sort the keys using the string values before printing.
The text was updated successfully, but these errors were encountered:
nvmkuruc
added
help wanted
Indicates an issue where help and/or a pull request from the community would be very welcome
good first issue
Indicates a good issue for first-time contributors
and removed
good first issue
Indicates a good issue for first-time contributors
labels
Nov 7, 2024
Some of the MaterialX shader codegen uses unordered data structures, and this reflects in the output shader. This causes problems for tests which are comparing against a static baseline. For example,
testHdStMaterialXShaderGen_UsdPStextured
has these lineswhich will change order according to the stdlib implementation. On macOS, I observe
and the test fails.
This is because the lines are printed in the order of
_mxHdTextureMap
, which is aMaterialX::StringMap
akastd::unordered_map<std::string, std::string>
(seepxr/imaging/hdSt/materialXShaderGen.cpp
).Either the testing baseline check needs to be smarter to handle undefined ordering where they can occur, or the codegen needs to sort the keys using the string values before printing.
The text was updated successfully, but these errors were encountered: