Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Components] zip_archive_api #11789

Closed
pipedream-component-development opened this issue May 1, 2024 · 5 comments · Fixed by #11827
Closed

[Components] zip_archive_api #11789

pipedream-component-development opened this issue May 1, 2024 · 5 comments · Fixed by #11827
Assignees
@lcaresia
Labels
triaged For maintainers: This issue has been triaged by a Pipedream employee

Comments

@pipedream-component-development
Copy link
Collaborator

zip_archive_api

URLs
@dylburger dylburger added the triaged For maintainers: This issue has been triaged by a Pipedream employee label May 1, 2024
@lcaresia lcaresia self-assigned this May 6, 2024
@lcaresia lcaresia linked a pull request May 6, 2024 that will close this issue
[Components] zip_archive_api #11789 #11827
Merged
@GTFalcao
Copy link
Collaborator

GTFalcao commented May 6, 2024

@vunguyenhung @malexanderlim I've commented on a usability concern on this issue's PR - it seems this API supports file uploading (via form-data), if that's the case, our components should probably support that as well.

@malexanderlim
Copy link
Collaborator

Thanks @GTFalcao . @lcaresia , could you implement to accept files both via File URL / using Form Data / application/octet-stream as well, to maintain maximum flexibility here?

@vunguyenhung
Copy link
Collaborator

Hello everyone, I have tested this PR and there're some test cases failed or needed improvement.

Please check the test report below for more information
https://vunguyenhung.notion.site/Components-zip_archive_api-3f0dbfdd65c94f9e9914d4669acd6ec2

@vunguyenhung
Copy link
Collaborator

Hello everyone, I have tested this PR and there're some test cases failed or needed improvement.

Please check the test report below for more information
https://vunguyenhung.notion.site/Components-zip_archive_api-3f0dbfdd65c94f9e9914d4669acd6ec2

@vunguyenhung
Copy link
Collaborator

Hi everyone, all test cases are passed! Ready for release!

Test report
https://vunguyenhung.notion.site/Components-zip_archive_api-3f0dbfdd65c94f9e9914d4669acd6ec2

lcaresia added a commit that referenced this issue Sep 5, 2024
@lcaresia
[Components] zip_archive_api #11789 (#11827)
2709077 
* Added actions

* Fixed requested changes

* Adding requested features

* Added actions

* Added actions

* Requested changes done

* Requested changes done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lcaresia lcaresia

Labels
triaged For maintainers: This issue has been triaged by a Pipedream employee
Projects
Component (Source and Action) Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Components] zip_archive_api #11789 PipedreamHQ/pipedream
6 participants
@dylburger @lcaresia @vunguyenhung @malexanderlim @GTFalcao @pipedream-component-development