Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote values in error messages #96

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Conversation

tylerjw
Copy link
Collaborator

@tylerjw tylerjw commented Oct 12, 2023

In preparing slides for my talk on generate_parameter_library I produced this error message:

  what():  Invalid value set during initialization for parameter 'my_string': 
Parameter 'my_string' with the value place is not in the set {world, base, home}

I think this would be much clearer if all the values in the error are quoted. The value place is kind of just hidden there in the middle.

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #96 (574076d) into main (0fbf42c) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #96   +/-   ##
=======================================
  Coverage   99.05%   99.05%           
=======================================
  Files          10       10           
  Lines         211      211           
=======================================
  Hits          209      209           
  Misses          2        2           
Flag Coverage Δ
humble 99.05% <100.00%> (ø)
rolling 99.05% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
include/rsl/parameter_validators.hpp 98.93% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link

@MarqRazz MarqRazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test but the changes look good.

@tylerjw tylerjw merged commit 5c0d774 into PickNikRobotics:main Oct 12, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants