Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more messages for assertion failures #101

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Add more messages for assertion failures #101

merged 1 commit into from
Dec 6, 2023

Conversation

ChrisThrasher
Copy link
Collaborator

@ChrisThrasher ChrisThrasher commented Dec 6, 2023

It's very user friendly to provide some explanation for why a compiletime or runtime assertion failed.

@ChrisThrasher
Copy link
Collaborator Author

I prefix uses of assert with the name of the function since at runtime it may not be obvious where the assertion failed. These strings make it easier to narrow down on exactly what API is being misused.

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c765c49) 99.06% compared to head (bb1bd7e) 99.06%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #101   +/-   ##
=======================================
  Coverage   99.06%   99.06%           
=======================================
  Files          11       11           
  Lines         215      215           
=======================================
  Hits          213      213           
  Misses          2        2           
Flag Coverage Δ
humble 99.06% <100.00%> (ø)
rolling 99.06% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tylerjw tylerjw merged commit 5f3214f into main Dec 6, 2023
35 checks passed
@delete-merged-branch delete-merged-branch bot deleted the assert_messages branch December 6, 2023 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants