Aruco/Multitag 36h11 support #981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amquake
reviewed
Oct 25, 2023
mcm001
reviewed
Oct 25, 2023
| /** | ||
| * Set the TargetModel representing the tags being detected. This is used for on-rio multitag. | ||
| * | ||
| * @param tagModel E.g. {@link TargetModel#kAprilTag16h5}. |
There was a problem hiding this comment.
I think this link is broken? Not sure, coz it doesn't include the size like we do in TargetModel above
There was a problem hiding this comment.
This is photon-targeting's TargetModel, not photon-core's. We should see if merging these is possible.
There was a problem hiding this comment.
Yeah totally. Or rename one of them lol
srimanachanta
commented
Oct 27, 2023
srimanachanta
commented
Oct 27, 2023
|
Java lint, but otherwise LGTM |
mcm001
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VisionEstimation.estimateCamPosePNP()now requires a target model instead of assuming 16h5PhotonPoseEstimatorcan have target model set for on-rio multitarget