Use protobufs for packed message data #974
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcm001
changed the title
|
When we bump spotless, there are protobuf options we can add, including license and some other stuff |
srimanachanta
force-pushed
the
2023-10-20_protobuf
branch
from
a87e9b1
to
29818c4
Compare
srimanachanta
force-pushed
the
2023-10-20_protobuf
branch
from
47dd8fc
to
c362730
Compare
|
Bump wpilib once the following are merged: |
Comment on lines
+119
to
+132
| it.binaries.all { | ||
| it.tasks.withType(CppCompile) { | ||
| it.dependsOn ":photon-targeting:generateProto" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| testSuites { | ||
| all { | ||
| it.binaries.all { | ||
| it.tasks.withType(CppCompile) { | ||
| it.dependsOn ":photon-targeting:generateProto" | ||
| } | ||
| } |
There was a problem hiding this comment.
Why does this need to be done? photon-lib shouldn't have a direct dependency on photon-targeting's generateProto task. This falls outside of my gradle knowledge so we may be doing something wrong/inefficently here
|
Benchmarking Data:
Protobuf:
|
|
Blocked by:
|
|
Most of the work was done by #1075, If we want to replace Pakcet with Protobuf, we need to reimplement that stuff into that new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: