Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[photon-client] Fix camera and pipeline name editing #969

Merged
merged 8 commits into from
Oct 21, 2023
Merged

[photon-client] Fix camera and pipeline name editing #969

merged 8 commits into from
Oct 21, 2023

Conversation

srimanachanta
Copy link
Member

closes #965

  • Had to disable the eslint rule that was causing the bug.
  • Disallows disabling driver mode when there are no other pipelines to swap to
  • Also adds icons for saving and canceling name edits
  • Adds the option to create a new pipeline in driver mode if there are no other pipelines
  • Adds disable prop to the driver mode switch on the camera settings page

@srimanachanta srimanachanta requested a review from a team as a code owner October 20, 2023 06:02
@srimanachanta srimanachanta added this to the 2024 Beta milestone Oct 20, 2023
@mcm001 mcm001 merged commit 8446c94 into PhotonVision:master Oct 21, 2023
21 checks passed
@srimanachanta srimanachanta deleted the fix-renamming branch October 21, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcm001 mcm001 mcm001 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2024 Beta
Development

Successfully merging this pull request may close these issues.

Changing camera and pipeline name not correctly saving on-enter
2 participants
@srimanachanta @mcm001